This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
Implement the RS01 consent content #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamilton
commented
Apr 9, 2021
| @@ -2,7 +2,7 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| export default { | |||
| module.exports = { | |||
There was a problem hiding this comment.
this was required to make storybook work again.
… fields because I forgot to do it months ago
hamilton
changed the title
hamilton
commented
Apr 9, 2021
rhelmer
reviewed
Apr 12, 2021
rhelmer
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
OK I've been testing this locally and lgtm, I tried dropping in https://github.com/mozilla-rally/study-remote-settings/pull/1 to locally-available-studies (with the URL modified to point to the latest RS01 on AMO) and it seems to be working fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527, closes #530, closes #537
This PR:
npm run storybookand check the flow story by clicking on the "join study" button)parseDateIfNeededfunction in the frontend as a workaround since we don't parse RS dates in the bg script