Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

adds rel="noopener noreferrer" to a tags with target="_blank" as suggested by security checklist #417

Merged
merged 2 commits into from
Feb 18, 2021
Merged

adds rel="noopener noreferrer" to a tags with target="_blank" as suggested by security checklist #417

merged 2 commits into from
Feb 18, 2021

Conversation

hamilton
Copy link
Contributor

Checklist for reviewer:

  • The description should reference a bug or github issue, if relevant.
  • There must be a CHANGELOG.md entry for any non-test change.
  • Any change to the NPM commands must be carefully reviewed to make sure it won't break the Add-ons pipeline.
  • Any version increase must follow the release process.

@hamilton hamilton requested a review from Dexterp37 February 18, 2021 15:19
Dexterp37
Dexterp37 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry before merging.

@hamilton hamilton force-pushed the add-rel-to-external-links branch from 6b7a140 to aa559b2 Compare February 18, 2021 15:24
@hamilton hamilton merged commit 3dfd3ca into mozilla-rally:master Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamilton @Dexterp37