Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Updates the "Manage Profile" consent flow; adds a global notification component #400

Merged
merged 12 commits into from
Mar 9, 2021
Merged

Updates the "Manage Profile" consent flow; adds a global notification component #400

merged 12 commits into from
Mar 9, 2021

Conversation

hamilton
Copy link
Contributor

@hamilton hamilton commented Feb 16, 2021 •
edited
Loading

closes #188, closes #394, closes #463

See the commit history.

Checklist for reviewer:

  • The description should reference a bug or github issue, if relevant.
  • There must be a CHANGELOG.md entry for any non-test change.
  • Any change to the NPM commands must be carefully reviewed to make sure it won't break the Add-ons pipeline.
  • Any version increase must follow the release process.

@hamilton hamilton marked this pull request as draft February 16, 2021 23:22
@hamilton hamilton changed the title Manage profile flow revamp creates a single global notification component Feb 16, 2021
@hamilton hamilton changed the title creates a single global notification component Updates the "Manage Profile" consent flow; adds a global notification component Feb 16, 2021
@hamilton hamilton marked this pull request as ready for review February 17, 2021 19:56
@hamilton hamilton marked this pull request as draft February 17, 2021 20:03
@hamilton hamilton marked this pull request as ready for review February 18, 2021 03:51
@hamilton hamilton force-pushed the manage-profile-flow-revamp branch from c7c8005 to f76e060 Compare February 24, 2021 18:50
@hamilton hamilton requested a review from Dexterp37 February 24, 2021 18:51
Dexterp37
Dexterp37 suggested changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, minus the nit. @hamilton would you consider holding off merging this PR until we cut the next release?

src/routes/NotificationCenter.svelte Outdated Show resolved Hide resolved
@hamilton hamilton force-pushed the manage-profile-flow-revamp branch from f76e060 to b338417 Compare March 2, 2021 04:23
@hamilton hamilton requested a review from Dexterp37 March 2, 2021 04:25
@hamilton hamilton mentioned this pull request Mar 2, 2021
Closed
@Dexterp37 Dexterp37 merged commit ee9957f into mozilla-rally:master Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hamilton @Dexterp37