Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Commit

Permalink
Merge pull request #656 from rhelmer/format-manifest-json-for-amo
Browse files Browse the repository at this point in the history
Pre-format manifest.json in a way AMO is happy with.
  • Loading branch information
rhelmer authored Jun 14, 2021
2 parents 3cc2745 + d2b8c85 commit 97e00e4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 15 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.3.2...master)

* [#656](https://github.com/mozilla-rally/rally-core-addon/pull/656): Pre-format manifest.json in a way AMO likes, to work around AMO bug.
* [#653](https://github.com/mozilla-rally/rally-core-addon/pull/653): Bump rally.js version to 0.7.0
* [#651](https://github.com/mozilla-rally/rally-core-addon/pull/651): Pass Rally ID during core-check response, for use by glean in studies.

Expand Down
33 changes: 18 additions & 15 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,23 @@
"name": "Mozilla Rally",
"version": "1.3.2",
"homepage_url": "https://github.com/mozilla-rally/rally-core-addon",

"icons": {
"48": "public/img/rally-favicon.svg",
"96": "public/img/rally-favicon.svg"
},

"applications": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "80.0a1"
}
},

"permissions": [
"management",
"telemetry",
"storage",
"https://firefox.settings.services.mozilla.com/",
"https://incoming.telemetry.mozilla.org/"
],

"telemetry": {
"pioneer_id": true,
"study_name": "rally-core",
Expand All @@ -41,37 +37,44 @@
}
}
},

"background": {
"scripts": ["public/addon-build/background.js"]
"scripts": [
"public/addon-build/background.js"
]
},

"content_scripts": [
{
"matches": ["https://rally.mozilla.org/*"],
"js": ["public/addon-build/content-script.js"]
"matches": [
"https://rally.mozilla.org/*"
],
"js": [
"public/addon-build/content-script.js"
]
}
],

"browser_action": {
"browser_style": true,
"default_icon": "public/img/rally-toolbar-icon.svg"
},

"options_ui": {
"page": "public/index.html",
"open_in_tab": true
},

"experiment_apis": {
"firefoxPrivilegedApi": {
"schema": "core-addon/FirefoxPrivilegedApi.schema.json",
"parent": {
"scopes": ["addon_parent"],
"scopes": [
"addon_parent"
],
"script": "core-addon/FirefoxPrivilegedApi.js",
"events": [],
"paths": [["firefoxPrivilegedApi"]]
"paths": [
[
"firefoxPrivilegedApi"
]
]
}
}
}
}
}

1 comment on commit 97e00e4

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-rally/rally-core-addon:tag:rallyjs-0.7.0","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-rally/rally-core-addon:branch:rallyjs-0.7.0

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-rally/rally-core-addon:branch:rallyjs-0.7.0",
    "queue:route:checks",
    "queue:route:index.xpi.v2.rally-core-addon.revision.97e00e458ab112346f779fd58c4846ea95bd6e7e.taskgraph.decision",
    "queue:create-task:project:none",
    "queue:scheduler-id:xpi-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:xpi-1/decision",
        "queue:create-task:very-high:xpi-1/decision",
        "queue:create-task:high:xpi-1/decision",
        "queue:create-task:medium:xpi-1/decision",
        "queue:create-task:low:xpi-1/decision",
        "queue:create-task:very-low:xpi-1/decision",
        "queue:create-task:lowest:xpi-1/decision"
      ]
    }
  ]
}

  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2021-06-14T23:19:33.780Z

Please sign in to comment.