Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Commit

Permalink
Merge branch 'release-v1.3.0' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
rhelmer committed May 20, 2021
2 parents 1c29911 + 1126da4 commit 7ea5af3
Show file tree
Hide file tree
Showing 19 changed files with 5,738 additions and 7,674 deletions.
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/implement-study-card-core-add-on.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: Implement Study Card Core Add On
about: Implement UX study card within the core addon.
title: "<Study Name>: Implement Study Card Core Add On"
labels: ''
assignees: ''

---

Implement UX study card within the core addon.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Unreleased changes

[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.2.1...master)
[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.3.0...master)

# v1.3.0 (2021-05-19)

[Full changelog](https://github.com/mozilla-rally/core-addon/compare/v1.2.1...v1.3.0)

* [#555](https://github.com/mozilla-rally/rally-core-addon/pull/555): Update the income question in the demographic survey to take in an integer.
* [#601](https://github.com/mozilla-rally/rally-core-addon/pull/601): Enable submitting data with Glean in addition to the legacy collection.

# v1.2.1 (2021-04-27)

Expand Down
4 changes: 4 additions & 0 deletions core-addon/Core.js
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,10 @@ export default class Core {
await this._storage.setRallyID(rallyId);
await this._storage.setDeletionID(deletionId);

// We enrolled in the Rally platform, we're now good
// to start uploading data if needed.
Glean.setUploadEnabled(true);

rallyMetrics.id.set(rallyId);

// Override the uninstall URL to include the rallyID, for deleting data without exposing the Rally ID.
Expand Down
13 changes: 11 additions & 2 deletions core-addon/DataCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ const CORE_ENCRYPTION_JWK = {
"y": "xrLUev8_yUrSFAlabnHInvU4JKc6Ew3YXaaoDloQxw8",
};

const GLEAN_ENCRYPTION_JWK = {
"crv": "P-256",
"kid": "rally-core",
"kty": "EC",
"x": "m7Gi2YD8DgPg3zxora5iwf0DFL0JFIhjoD2BRLpg7kI",
"y": "zo35XIQME7Ct01uHK_LrMi5pZCuYDMhv8MUsSu7Eq08",
};

export default class DataCollection {
/**
* Initializes the data collection engine.
Expand All @@ -28,7 +36,7 @@ export default class DataCollection {
* Whether or not user has enrolled in the platform.
*/
initialize(userEnrolled) {
if (!__ENABLE_GLEAN__) {
if (!__ENABLE_DATA_SUBMISSION__ || !__ENABLE_GLEAN__) {
console.warn("DataCollection - Glean disabled by the build configuration.");
return;
}
Expand All @@ -37,8 +45,9 @@ export default class DataCollection {
// consented to join Rally. Upload is always enabled unless the web-extension
// is uninstalled.
Glean.initialize("rally-core", userEnrolled, {
appDisplayVersion: browser.runtime.getManifest().version,
plugins: [
new PingEncryptionPlugin(CORE_ENCRYPTION_JWK)
new PingEncryptionPlugin(GLEAN_ENCRYPTION_JWK)
]
}
);
Expand Down
5 changes: 3 additions & 2 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"author": "Mozilla",
"manifest_version": 2,
"name": "Mozilla Rally",
"version": "1.2.1",
"version": "1.3.0",
"homepage_url": "https://github.com/mozilla-rally/rally-core-addon",

"icons": {
Expand All @@ -22,7 +22,8 @@
"management",
"telemetry",
"storage",
"https://firefox.settings.services.mozilla.com/"
"https://firefox.settings.services.mozilla.com/",
"https://incoming.telemetry.mozilla.org/"
],

"telemetry": {
Expand Down
Loading

1 comment on commit 7ea5af3

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-rally/rally-core-addon:tag:v1.3.0","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-rally/rally-core-addon:branch:v1.3.0

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-rally/rally-core-addon:branch:v1.3.0",
    "queue:route:checks",
    "queue:route:index.xpi.v2.rally-core-addon.revision.7ea5af309f8d9a6e1c6c9f790daa22fdfd6f6bfd.taskgraph.decision",
    "queue:create-task:project:none",
    "queue:scheduler-id:xpi-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:xpi-1/decision",
        "queue:create-task:very-high:xpi-1/decision",
        "queue:create-task:high:xpi-1/decision",
        "queue:create-task:medium:xpi-1/decision",
        "queue:create-task:low:xpi-1/decision",
        "queue:create-task:very-low:xpi-1/decision",
        "queue:create-task:lowest:xpi-1/decision"
      ]
    }
  ]
}

  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2021-05-20T02:14:30.693Z

Please sign in to comment.