Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Fix MSVC warning #9995

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Nit: Fix MSVC warning #9995

merged 1 commit into from
Oct 31, 2024

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Oct 29, 2024

Description

Clang auto infers that all code-paths return a value .... msvc is unable to do so and therefore throws an error :)

Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@strseb strseb merged commit a18c1fa into main Oct 31, 2024
117 checks passed
@strseb strseb deleted the basti/msvc_nit branch October 31, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants