Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-218: Fix busted split tunneling on Linux #9987

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Oct 25, 2024

Description

In PR #9906 I messed around a bit with the firewall rules to get IPv6 traffic to split tunnel correctly when originating with a firewall mark (eg: sudo ping6 -m 51820 <dest>) by making better use of connection tracking to re-set the firewall mark upon packet reception.

However, I goofed up during the rebase and I forgot the most important part of that change: the firewall mark has to be applied after connection tracking, and unfortunately a raw hook happens before connection tracking. The result of that error is that split tunneling just doesn't work on some machines because the inbound packets loose their firewall mark and get rejected by RPF.

To fix this, we just need to adjust the priority of the preroute chain from ChainPriorityRaw to ChainPriorityMangle so that it happens after connection tracking.

Reference

Bug introduced by #9906
Related JIRA Issue: FXVPN-218

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman removed their request for review October 28, 2024 12:56
@oskirby oskirby merged commit a4b91c0 into main Nov 12, 2024
114 checks passed
@oskirby oskirby deleted the fxvpn-218-fix-linux-split-tunnel branch November 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants