-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re:#9966 Fix Crash in MZFlickable #9984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt 6.8.0 no longer links to this it seems so we need to manually declare that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For windows at least, I think we tend to handle this using pragmas: #pragma comment(lib, "Iphlpapi")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This errored and i think noone is using it, so let's just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qAsConst is depricated in 6.8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just one minor nitpick about how to link libraries on Windows, but it's not worth holding the patch up if you feel strongly about it.
Hi @strseb I am not sure if the purpose of this PR is fix all the problems with Qt6.8, I applied this patch (also this one 9961) to the stable version, and the UI is usable, but one thing is not working, when I click in the list of servers "Select location", the UI crash with the following traceback: |
Hey @XavierCLL - i was not expecting one small patch to magically fix all issues that might arise with 6.8 :) |
Soooo i did set up a 6.8 dev build and was able to repro the crash seen in #9966 - this is a fun one.
In 6.8.0 we get the "onHeightChange" before the window has finished to initialize, so that when we call
mapToItem(window.contentItem)
we defer a nullptr and crash.