Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-3112: read title for a11y link #9971

Merged
merged 1 commit into from
Oct 24, 2024
Merged

VPN-3112: read title for a11y link #9971

merged 1 commit into from
Oct 24, 2024

Conversation

mcleinman
Copy link
Collaborator

Description

QA caught that we're missing accessibility text for the button; it was reading as "unlabeled".

Reference

VPN-3112

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

oskirby
oskirby approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mcleinman mcleinman merged commit 3cf875a into main Oct 24, 2024
114 checks passed
@mcleinman mcleinman deleted the vpn-3112-accessibility-button-label branch October 24, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskirby oskirby oskirby approved these changes

@lesleyjanenorton lesleyjanenorton Awaiting requested review from lesleyjanenorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcleinman @oskirby