Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix flaky subscription test #9330

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Apr 4, 2024

Description

We have been seeing a bunch of flaky test failures in the testSubscription.js functional test. This seems to occur when checking the subscription management links, and the logs appear to show the test failing to register a click of the various subscription management buttons. I suspect that the cause of the failure is clicking too soon after opening the subscription management view, so we try to work around it by waiting for the stackview to finish its transition.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review April 4, 2024 22:50
@oskirby oskirby requested review from mcleinman and strseb April 5, 2024 14:29
@oskirby oskirby merged commit dfc550e into main Apr 8, 2024
127 of 129 checks passed
@oskirby oskirby deleted the chore-fix-flaky-subscription-tests branch April 8, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants