Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Move i18n folder into 3rdparty folder #9309

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Apr 2, 2024

This is an experiment, I want to see what explodes. Nothing exploded.

@brizental brizental requested a review from strseb April 2, 2024 13:28
@brizental brizental force-pushed the chore-move-i18n branch 2 times, most recently from 1dabb0e to 20f8af3 Compare April 2, 2024 14:19
@brizental brizental requested a review from flodolo April 2, 2024 14:31
@brizental
Copy link
Contributor Author

brizental commented Apr 2, 2024

@flodolo Does this change require any changes on the l10n repo? If so, is it an issue?

Note, this is not really a required change... so no hard sell here. It's just a yak shave honestly.

@flodolo
Copy link
Collaborator

flodolo commented Apr 2, 2024

@flodolo Does this change require any changes on the l10n repo? If so, is it an issue?

Not that I'm aware of.

@brizental brizental marked this pull request as ready for review April 3, 2024 13:23
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarification, why was the systemLanguageCodeMigrated setting removed?

@brizental
Copy link
Contributor Author

brizental commented Apr 5, 2024

Just for clarification, why was the systemLanguageCodeMigrated setting removed?

Yeap, that was a bonus. Sorry I forgot to mention it in the PR description, it's very old migration code. See e07e1d9

@brizental brizental enabled auto-merge (squash) April 5, 2024 15:29
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label Apr 5, 2024
@brizental brizental merged commit 49ee06f into main Apr 5, 2024
131 of 133 checks passed
@brizental brizental deleted the chore-move-i18n branch April 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants