Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6215 : Fix navbar visibility after viewing reset options #9248

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Mar 19, 2024

Description

This PR removes property bool wasNavbarVisible from ViewReset.qml to fix VPN-6215 because:

  • wasNavbarVisible overwrites the default navbar visibility handling which causes the navbar to erroneously stay visible after logout.
  • The wasNavBarVisible property is not needed given navbar visibilit is handled in the above code chunk, even when on the Get help menu and Get help sub pages.

Reference

VPN-6215

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Nice find!

@lesleyjanenorton lesleyjanenorton merged commit 280100e into main Mar 25, 2024
129 checks passed
@lesleyjanenorton lesleyjanenorton deleted the fix-vpn-6215 branch March 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants