Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Add explicit python dependency on colorama #9094

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Feb 6, 2024

Description

We have had a string of dependabot PR's that fail to build on Windows and after some digging it seems that the problem is due to a Windows-only dependency on the colorama package. We don't explicitly use this anywhere, but it gets pulled in via Glean (glean-parser -> click -> colorama).

However, dependabot doesn't seem to process platform-specific dependencies so this gets completely ignored and is automatically stripped out everytime it tries to update requirements.txt. To fix this, let's just add an explicit dependency on colorama.

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the nit-explicit-colorama-dependency branch from aec268a to bc3fe72 Compare February 6, 2024 22:16
@oskirby oskirby marked this pull request as ready for review February 6, 2024 23:07
@oskirby oskirby requested a review from strseb February 6, 2024 23:07
@oskirby oskirby force-pushed the nit-explicit-colorama-dependency branch from bc3fe72 to 03915e2 Compare February 7, 2024 16:41
@oskirby oskirby enabled auto-merge (squash) February 7, 2024 17:29
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label Feb 7, 2024
@oskirby oskirby merged commit 72308d1 into main Feb 7, 2024
136 checks passed
@oskirby oskirby deleted the nit-explicit-colorama-dependency branch February 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants