Nit: Add explicit python dependency on colorama #9094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have had a string of dependabot PR's that fail to build on Windows and after some digging it seems that the problem is due to a Windows-only dependency on the colorama package. We don't explicitly use this anywhere, but it gets pulled in via Glean (glean-parser -> click -> colorama).
However, dependabot doesn't seem to process platform-specific dependencies so this gets completely ignored and is automatically stripped out everytime it tries to update
requirements.txt
. To fix this, let's just add an explicit dependency on colorama.Checklist