VPN-4690: Add excluded apps help sheet #8879
Conversation
src/translations/strings.yaml
Outdated
| value: What are excluded apps? | ||
| comment: Header label for the excluded apps help sheet | ||
| excludedAppsBody1: | ||
| value: Excluded apps let you turn off VPN protection for specific apps, without turning off your device’s VPN protection. |
There was a problem hiding this comment.
Is it just me, or this can be confusing? It makes it sound like the device has a VPN protection that is unrelated to Mozilla VPN, unlike something like this:
… without turning off VPN protection for your entire device.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure, we can make this change. Let's update to Flod's suggestion:
Excluded apps let you turn off VPN protection for specific apps, without turning off VPN protection for your entire device.
src/translations/strings.yaml
Outdated
| value: Excluded apps let you turn off VPN protection for specific apps, without turning off your device’s VPN protection. | ||
| comment: Body label for the excluded apps help sheet | ||
| excludedAppsBody2: | ||
| value: When you exclude an app, your IP address and approximate location will be exposed to it. |
There was a problem hiding this comment.
| value: When you exclude an app, your IP address and approximate location will be exposed to it. | |
| value: When you exclude an app, it will have access to your IP address and approximate location. |
In case content needs to check these strings, this feels a bit easier to read.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure, I also like this suggestion.
Thanks Flod.
src/mozillavpn.cpp
Outdated
| @@ -1381,6 +1381,11 @@ void MozillaVPN::registerUrlOpenerLabels() { | |||
| uo->registerUrlLabel("upgradeToAnnualUrl", []() -> QString { | |||
| return Constants::upgradeToAnnualUrl(); | |||
| }); | |||
|
|
|||
| uo->registerUrlLabel("sumoExcludedApps", []() -> QString { | |||
| return "https://support.mozilla.org/en-US/kb/" | |||
There was a problem hiding this comment.
let's drop the "en-US" here because it stipulates that the page is shown in English. Without it, moz.org will route the page based on the person's browser language prefs.
| title: MZI18n.HelpSheetsExcludedAppsTitle | ||
|
|
||
| model: [ | ||
| {type: MZHelpSheet.BlockType.Title, text: MZI18n.HelpSheetsExcludedAppsHeader}, |
There was a problem hiding this comment.
will add to theme.js to be used by all help sheets in a fast follow
| model: [ | ||
| {type: MZHelpSheet.BlockType.Title, text: MZI18n.HelpSheetsExcludedAppsHeader}, | ||
| {type: MZHelpSheet.BlockType.Text, text: MZI18n.HelpSheetsExcludedAppsBody1, margin: 8}, | ||
| {type: MZHelpSheet.BlockType.Text, text:MZI18n.HelpSheetsExcludedAppsBody2, margin: 16}, |
There was a problem hiding this comment.
text:MZI18n.HelpSheetsExcludedAppsBody2
nit: space between 'text:' and 'MZ...'
MattLichtenstein
force-pushed
the
VPN-4690
branch
from
7e10c55 to
9d759aa
Compare
Description
NOTE: Depends on #8864: VPN-4687: Add DNS settings help sheet
Screen.Recording.2023-12-29.at.2.44.02.PM.mov
Reference
VPN-4690: Implement the 'App Exclusions' in-product help sheet