Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-4987 [Part 1] - Check for internet connectivity upon activation + VPN-5994 - Inspector command #8834

Merged
merged 10 commits into from
Jan 19, 2024

Conversation

Gela
Copy link

@Gela Gela commented Dec 18, 2023

Description

This PR does 2 things:

  1. Check for internet connection upon activation. This is the backend code only, frontend will be completed in a later sprint
  2. Add inspector command force_connection_down to mock network connection being down.

Please note that functional tests cannot be added until the front end work is done.

Reference

https://mozilla-hub.atlassian.net/browse/VPN-5994
https://mozilla-hub.atlassian.net/browse/VPN-4987

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@Gela Gela requested a review from vinocher December 18, 2023 20:05
@Gela Gela self-assigned this Dec 18, 2023
@Gela Gela changed the title VPN-4987 [Part 1] - Check for internet connectivity upon activation VPN-4987 [Part 1] - Check for internet connectivity upon activation + VPN-5994 - Inspector command Dec 18, 2023
src/controller.h Outdated Show resolved Hide resolved
src/controller.cpp Outdated Show resolved Hide resolved
@Gela Gela force-pushed the gela/reachability3 branch from 79efaa4 to 1ccceb8 Compare December 18, 2023 22:50
@Gela Gela requested a review from vinocher December 18, 2023 23:23
Copy link
Contributor

@vinocher vinocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gela Gela force-pushed the gela/reachability3 branch from b6e4245 to c9b9210 Compare January 2, 2024 16:46
@Gela Gela merged commit 95a0acb into main Jan 19, 2024
125 checks passed
@Gela Gela deleted the gela/reachability3 branch January 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants