-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPN-4987 [Part 1] - Check for internet connectivity upon activation + VPN-5994 - Inspector command #8834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gela
changed the title
VPN-4987 [Part 1] - Check for internet connectivity upon activation
VPN-4987 [Part 1] - Check for internet connectivity upon activation + VPN-5994 - Inspector command
Dec 18, 2023
vinocher
reviewed
Dec 18, 2023
Gela
force-pushed
the
gela/reachability3
branch
from
December 18, 2023 22:50
79efaa4
to
1ccceb8
Compare
vinocher
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Gela
force-pushed
the
gela/reachability3
branch
from
December 19, 2023 00:22
e4418e9
to
44d2503
Compare
This was referenced Dec 19, 2023
Gela
force-pushed
the
gela/reachability3
branch
from
December 20, 2023 01:19
a26f7b9
to
596f5d1
Compare
5 tasks
Gela
force-pushed
the
gela/reachability3
branch
from
January 2, 2024 15:28
596f5d1
to
89e959e
Compare
Gela
force-pushed
the
gela/reachability3
branch
from
January 2, 2024 16:46
b6e4245
to
c9b9210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
Please note that functional tests cannot be added until the front end work is done.
Reference
Checklist