Adjust fixes for Android client: add a network conf, change how token is passed to gradle #8824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </trust-anchors> | ||
| </base-config> | ||
| <domain-config cleartextTrafficPermitted="false"> | ||
| <domain includeSubdomains="true">mozilla.org</domain> |
There was a problem hiding this comment.
++ mozaws.net and allizom.org I think?
brizental
reviewed
Dec 18, 2023
strseb
commented
Dec 18, 2023
| @@ -190,7 +183,7 @@ cd .tmp/src/android-build/ | |||
| if [[ "$RELEASE" ]]; then | |||
| print Y "Generating Release APK..." | |||
| ./gradlew compileReleaseSources | |||
| ./gradlew assemble || die | |||
There was a problem hiding this comment.
Thanks @mcleinman thats waaay better!
brizental
approved these changes
Dec 18, 2023
lesleyjanenorton
approved these changes
Dec 18, 2023
mcleinman
changed the title
mcleinman
added a commit
that referenced
this pull request
Dec 18, 2023
… is passed to gradle (#8824) * Add a network conf to the android client * pass in variable * per review --------- Co-authored-by: Matt Cleinman <[email protected]>
mcleinman
added a commit
that referenced
this pull request
Dec 18, 2023
… is passed to gradle (#8824) (#8833) * Add a network conf to the android client * pass in variable * per review --------- Co-authored-by: Sebastian Streich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part two of VPN-5822.
A write up of the issues this fixes is in the ticket: https://mozilla-hub.atlassian.net/browse/VPN-5822?focusedCommentId=809828
Description
Instead of a bool, let's enforce https for all known domains the client can talk to.