Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-5900 (part 2): Don't send Android daemon metrics when switching server #8793

Merged
merged 2 commits into from
Dec 12, 2023
Merged

VPN-5900 (part 2): Don't send Android daemon metrics when switching server #8793

merged 2 commits into from
Dec 12, 2023

Conversation

mcleinman
Copy link
Collaborator

Description

In testing #8698, QA noticed that Android sent daemon pings for server switches. iOS has never done this, and so this fixes the behavior on Android.

Reference

VPN-5900

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested review from Gela and strseb December 11, 2023 20:24
@mcleinman mcleinman merged commit 3b34f68 into main Dec 12, 2023
125 checks passed
@mcleinman mcleinman deleted the vpn-5900-android-daemon branch December 12, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gela Gela Gela approved these changes

@strseb strseb Awaiting requested review from strseb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcleinman @Gela