Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-5439: Use 'Pane' for a11y role instead of 'Grouping' #8792

Merged
merged 1 commit into from
Dec 14, 2023
Merged

VPN-5439: Use 'Pane' for a11y role instead of 'Grouping' #8792

merged 1 commit into from
Dec 14, 2023

Conversation

vinocher
Copy link
Contributor

@vinocher vinocher commented Dec 11, 2023 •
edited
Loading

Description

Use 'Pane' for a11y role in a view because 'Grouping' caused VoiceOver ScreenReader quick-nav problems in macOS

Reference

VPN-5439, GitHub 8751

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@vinocher vinocher self-assigned this Dec 11, 2023
@vinocher vinocher merged commit 21050cf into main Dec 14, 2023
125 checks passed
@vinocher vinocher deleted the vinocher/a11yRoleFix branch December 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattLichtenstein MattLichtenstein MattLichtenstein approved these changes

Assignees

@vinocher vinocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinocher @MattLichtenstein