Show users with passwordless accounts a meaningful error message #8663
Conversation
jswinarton
force-pushed
the
5089-handle-passwordless
branch
5 times, most recently
from
fbc73a4 to
8a4dd91
Compare
jswinarton
force-pushed
the
5089-handle-passwordless
branch
12 times, most recently
from
95a00e8 to
062fac6
Compare
jswinarton
force-pushed
the
5089-handle-passwordless
branch
from
062fac6 to
bea9410
Compare
nebula/ui/components/inAppAuth/MZInAppAuthenticationThirdParty.qml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,34 @@ | |||
| /* This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
This view highly resembles ViewErrorFullScreen.qml, any opportunity to reuse that here and consolidate MZInAppAuthenticationThirdParty into ViewAuthenticationSsoAccount since MZInAppAuthenticationThirdParty is not super reusable? I only suggest this as I think it would save us some complexity within in-app auth. What do you think?
There was a problem hiding this comment.
a little cut off on mobile... maybe something to do with the ios safe area?
There was a problem hiding this comment.
also, the buttons should be higher on desktop, according to the mockups
There was a problem hiding this comment.
Re: factoring this into ViewErrorFullScreen.qml -- you are correct that it is a close copy, it was actually what I originally copied to create the base view. The only reason I didn't put more work into factoring this out is because the current plan for in-app auth is to tear it out and replace it with FxA browser based auth in Q1. We are still trying to figure out exactly what this will look like, which is why we are adding these screens as a stop gap to prevent user issues in the short term. Since this will almost certainly go away soon I feel it's probably not worth the effort.
Still working on the layout issues.
There was a problem hiding this comment.
Addressed the button height issue by adding a vertical spacer in the same manner as in ViewSubscriptionNeeded.qml.
|
|
||
| MZButton { | ||
| objectName: "buttonSignIn" | ||
| text: "Continue to sign in" |
There was a problem hiding this comment.
this needs to go in strings.yaml
There was a problem hiding this comment.
this is marked as resolved, but a hardcoded string is still being used
There was a problem hiding this comment.
Sorry about this, not sure how that happened. Should be up to date now.
jswinarton
force-pushed
the
5089-handle-passwordless
branch
from
bea9410 to
7172cbd
Compare
jswinarton
force-pushed
the
5089-handle-passwordless
branch
from
13a206f to
210ddf0
Compare
Co-authored-by: Francesco Lodolo <[email protected]>
Co-authored-by: Matt Lichtenstein <[email protected]>
Description
Prior to this PR, when a user attempted to log in using either an FxA "stub" account (i.e. an account without a password) or an SSO-linked account without a password, the client would display a generic error message. This PR adds views that show the users actionable messages that guide them through the steps necessary to set a password on their FxA account.
Reference
Fixes VPN-5089 and VPN-5871
Checklist
I have commented my code PARTICULARLY in hard to understand areas(N/A)