Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-5740 - Add force_backend_failure to inspector commands (#8341) #8380

Merged
merged 1 commit into from
Oct 24, 2023
Merged

VPN-5740 - Add force_backend_failure to inspector commands (#8341) #8380

merged 1 commit into from
Oct 24, 2023

Conversation

Gela
Copy link

@Gela Gela commented Oct 24, 2023 •
edited
Loading

Description

Cherry pick this PR to 2.18 so QA can test certain functionalities.

Reference

main branch PR: https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8341

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@Gela
VPN-5740 - Add force_backend_failure to inspector commands (#8341)
ae80139 
* Add mockSomethingWentWrong to inspector commands

* change command name to force_backend_failure

* fixup! change command name to force_backend_failure

* Reorg commands alphabetically
@Gela Gela requested review from mcleinman and brizental October 24, 2023 16:09
mcleinman
mcleinman approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Gela Gela added the 🛬 Landing This PR is marked as "auto-merge" label Oct 24, 2023
@Gela Gela merged commit 1351d66 into releases/2.18.0 Oct 24, 2023
75 of 76 checks passed
@Gela Gela deleted the gela/backendFailureCmd branch October 24, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcleinman mcleinman mcleinman approved these changes

@brizental brizental Awaiting requested review from brizental

Assignees
No one assigned
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gela @mcleinman