VPN-5733: Fix account deletion word wrapping #8326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcleinman
reviewed
Oct 18, 2023
| @@ -64,7 +64,7 @@ RowLayout { | |||
| Layout.fillWidth: true | |||
| text: subLabelText | |||
| visible: !!subLabelText.length | |||
| wrapMode: Text.WordWrap | |||
| wrapMode: Text.Wrap | |||
There was a problem hiding this comment.
Why not WrapAtWordBoundaryOrAnywhere?
There was a problem hiding this comment.
They appear to be the same thing, though WrapAtWordBoundaryOrAnywhere is not documented for use in QML
There was a problem hiding this comment.
Thanks, sorry for missing that documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MZCheckBoxRowsublabels, let wrap on a word ending if possible, otherwise, wrap on character (instead of only wrapping on word ending)Reference
VPN-5733: Delete Mozilla account screen has UI issues for some languages