Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-5635: 2.18 update message #8317

Merged
merged 3 commits into from
Oct 18, 2023
Merged

VPN-5635: 2.18 update message #8317

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9792ad
2.18 update message
MattLichtenstein Oct 17, 2023
4469f8e
remove debug code
MattLichtenstein Oct 17, 2023
2fb8136
version number typo
MattLichtenstein Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions addons/message_update_v2.17/enable.js → addons/message_update_v2.18/enable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
(function (api) {
// "Extra" fields are used only to get a localized string.
api.addon.composer.remove('extra_1_217');
api.addon.composer.remove('extra_1');

if (('updateTime' in api.settings)) {
api.addon.date = (api.settings.updateTime.getTime() / 1000);
Expand All @@ -10,7 +10,7 @@
// Macos v2.16.0 requires a web-based update.
if (api.env.platform === 'macos' && api.env.versionString === '2.16.0') {
api.addon.setTitle(
'message.message_update_v2.17.block.extra_1_217',
'message.message_update_v2.18.block.extra_1',
'Download the new Mozilla VPN');
api.addon.composer.remove('c_3');
return;
Expand Down Expand Up @@ -51,6 +51,6 @@
api.addon.composer.remove('c_3');

api.addon.setTitle(
'message.message_update_v2.17.block.extra_1_217',
'message.message_update_v2.18.block.extra_1',
'Download the new Mozilla VPN');
})
0 addons/message_update_v2.17/getHelp.js → addons/message_update_v2.18/getHelp.js
View file
Open in desktop
File renamed without changes.
16 changes: 8 additions & 8 deletions addons/message_update_v2.17/manifest.json → addons/message_update_v2.18/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"api_version": "0.1",
"id": "message_update_v2.17",
"name": "Update to Mozilla VPN 2.17",
"id": "message_update_v2.18",
"name": "Update to Mozilla VPN 2.87",
"type": "message",
"conditions": {
"max_client_version": "2.16.9"
"max_client_version": "2.17.9"
},
"javascript": {
"enable": "enable.js"
},
"message": {
"date": 1671066000,
"id": "message_update_v2.17",
"title": "Update Mozilla VPN",
"id": "message_update_v2.18",
"title": "Update to Mozilla VPN 2.18",
"subtitle": "We’ve released an updated version of Mozilla VPN! Update to the latest version for the best possible Mozilla VPN experience.",
"badge": "new_update",
"blocks": [
Expand All @@ -27,7 +27,7 @@
"content": [
{
"id": "l_2",
"content": "A new “My Devices” screen that makes it easier to view and manage your devices"
"content": "The ability to upgrade to an annual plan from within the app"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string should be localized using machine memory as it was mozilla-l10n/mozilla-vpn-client-l10n#391

}
]
},
Expand All @@ -53,9 +53,9 @@
"javascript": "getHelp.js"
},
{
"id": "extra_1_217",
"id": "extra_1",
"type": "text",
"content": "Download the new Mozilla VPN"
"content": "Download the new Mozilla VPN 2.18"
}
]
}
Expand Down
0 addons/message_update_v2.17/update.js → addons/message_update_v2.18/update.js
View file
Open in desktop
File renamed without changes.
0 addons/message_update_v2.17/updateWeb.js → addons/message_update_v2.18/updateWeb.js
View file
Open in desktop
File renamed without changes.
Loading