Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-5697 - Allow account deletion on Android #8279

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

mcleinman
Copy link
Collaborator

Description

This was already implemented on iOS, so this was essentially just turning on the feature for Android. However, there were also some requests to improve the formatting and colors and spacing, so that is the bulk of this PR.

  • The formatting changes: Better spacing, more consistent font sizes, blue button color for the "Cancel" button.
  • Hiding elements w/ no content is to remove the additional spacing they were providing.
  • The addition to android.cmake (${Qt6_DIR}/../../libQt6Svg_${ANDROID_ABI}.so) is due to a note a few lines above what I added (along with a build error I experienced): android-deploy-qt is bad and randomly decides to not deploy some lib's we are linking to. So as long as qt is behaving bad, let's force the deployment. Feel free to add libs that are breaking on your build locally.

Mocks: https://www.figma.com/file/CIelhzmFVyDqn6gNvMXolc/Subscription-Management-In-App?type=design&node-id=2375-1618&mode=design&t=xmGujHUgHm1ldZDW-0

Before (cut off the red Cancel button, sorry)

After

Reference

https://mozilla-hub.atlassian.net/browse/VPN-5697

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman merged commit bbbaf01 into main Oct 13, 2023
86 checks passed
@mcleinman mcleinman deleted the vpn-5697-android-account-deletion branch October 13, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants