Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-5707 Remove the "Messages - REMOVE ME" option from the Developer menu #8270

Merged
merged 1 commit into from
Oct 12, 2023
Merged

VPN-5707 Remove the "Messages - REMOVE ME" option from the Developer menu #8270

merged 1 commit into from
Oct 12, 2023

Conversation

Gela
Copy link

@Gela Gela commented Oct 12, 2023

Description

Santiago said he hates it and we must keep Santiago happy so this has got to go. Sorry I don't make the rules! 😁

Reference

https://mozilla-hub.atlassian.net/browse/VPN-5705

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@Gela Gela requested a review from mcleinman October 12, 2023 05:07
@Gela Gela self-assigned this Oct 12, 2023
brizental
brizental reviewed Oct 12, 2023
View reviewed changes
src/ui/screens/getHelp/developerMenu/ViewMessages.qml
@@ -1,80 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not useful though? Why did that menu option even have the REMOVE ME in it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattLichtenstein Looks like this was added by you September of last year. Can you confirm that this isn't needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was actually a Baku thing - and I don't ever use this so delete away!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut reaction was that we should keep the menu, but I just opened it for the first time and it looks like it just displays the same messages that are in the inbox. I may be missing some functionality, but if that's all it is, I can't think of how it would be useful. If there is some additional functionality, I agree we should keep it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this view preceeded the message inbox UI. it was a way to test message addons (and before that, all addons) before we had proper UI

@Gela Gela requested a review from MattLichtenstein October 12, 2023 15:04
mcleinman
mcleinman approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Gela Gela merged commit bf50c45 into main Oct 12, 2023
83 checks passed
@Gela Gela deleted the gela/removeMe branch October 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brizental brizental brizental left review comments

@MattLichtenstein MattLichtenstein MattLichtenstein approved these changes

@mcleinman mcleinman mcleinman approved these changes

Assignees

@Gela Gela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gela @mcleinman @MattLichtenstein @brizental