VPN-2452 - Implement subscription expiring message #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
requested review from
bakulf,
mozrokafor,
birdsarah,
oskirby,
strseb,
flodolo and
MattLichtenstein
as code owners
brizental
force-pushed
the
VPN-2452-sub-expire
branch
from
4610e1a to
cf56a4c
Compare
flodolo
approved these changes
Jan 23, 2023
Codecov ReportBase: 28.30% // Head: 0.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5743 +/- ##
==========================================
- Coverage 28.30% 0.97% -27.33%
==========================================
Files 332 289 -43
Lines 22319 15912 -6407
Branches 12055 7621 -4434
==========================================
- Hits 6317 155 -6162
- Misses 10334 15568 +5234
+ Partials 5668 189 -5479
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bakulf
previously requested changes
Jan 24, 2023
brizental
force-pushed
the
VPN-2452-sub-expire
branch
6 times, most recently
from
ba75483 to
1f58a2c
Compare
|
Debugging notes for my tomorrow self: The subscription expiring addon is not being enabled or disabled, according to the logs. It is being loaded however. |
brizental
force-pushed
the
VPN-2452-sub-expire
branch
from
925bf1c to
53d8e76
Compare
brizental
force-pushed
the
VPN-2452-sub-expire
branch
from
1f100cc to
178b2b8
Compare
brizental
force-pushed
the
VPN-2452-sub-expire
branch
2 times, most recently
from
115f8af to
1ae8ad2
Compare
bakulf
approved these changes
Feb 7, 2023
| @@ -567,6 +567,24 @@ static QList<InspectorCommand> s_commands{ | |||
| return obj; | |||
| }}, | |||
|
|
|||
| InspectorCommand{"messages", "Returns a list of the loaded messages ids", 0, | |||
There was a problem hiding this comment.
We already have a similar method for guides. Wondering if we should return all the add-ons with types.
brizental
force-pushed
the
VPN-2452-sub-expire
branch
from
1ae8ad2 to
ff40a94
Compare
brizental
force-pushed
the
VPN-2452-sub-expire
branch
2 times, most recently
from
13cc889 to
2792130
Compare
brizental
force-pushed
the
VPN-2452-sub-expire
branch
from
2792130 to
4f01070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to reopen it for CI to be able to run fully.
Previous PR: #5273