Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding token to raise api limits #5264

Merged
merged 12 commits into from
Dec 21, 2022
Merged

adding token to raise api limits #5264

merged 12 commits into from
Dec 21, 2022

Conversation

mozrokafor
Copy link
Contributor

Description

Fixing rate limit issue in wasm tests

Reference

[VPN-3504](https://mozilla-hub.atlassian.net/browse/VPN-3504)

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

bakulf
bakulf previously requested changes Dec 20, 2022
Copy link
Collaborator

@bakulf bakulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix does not work. See the failing tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 30.56% // Head: 30.55% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a80563b) compared to base (2c26d86).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5264      +/-   ##
==========================================
- Coverage   30.56%   30.55%   -0.01%     
==========================================
  Files         336      336              
  Lines       23036    23038       +2     
  Branches    12528    12529       +1     
==========================================
- Hits         7041     7040       -1     
+ Misses       9732     9705      -27     
- Partials     6263     6293      +30     
Flag Coverage Δ
functional_tests 0.00% <ø> (ø)
linux_unit_tests 29.04% <ø> (-0.02%) ⬇️
lottie_tests 22.97% <ø> (ø)
macos_unit_tests 32.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/apps/vpn/externalophandler.cpp 36.17% <0.00%> (-0.79%) ⬇️
tests/unit/moccontroller.cpp 15.38% <0.00%> (-0.41%) ⬇️
src/apps/vpn/settingsholder.cpp 48.18% <0.00%> (-0.24%) ⬇️
src/apps/vpn/notificationhandler.cpp 13.88% <0.00%> (-0.10%) ⬇️
src/apps/vpn/frontend/navigator.cpp 32.46% <0.00%> (-0.09%) ⬇️
tests/unit/main.cpp 39.02% <0.00%> (ø)
src/apps/vpn/controller.h 20.00% <0.00%> (ø)
tests/qml/mocconstants.cpp 14.28% <0.00%> (ø)
src/apps/vpn/appconstants.h 20.00% <0.00%> (ø)
src/apps/vpn/settingslist.h 0.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@birdsarah birdsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working. It certainly doesn't hurt.

@birdsarah birdsarah dismissed bakulf’s stale review December 21, 2022 04:52

Changes have been made.

@birdsarah birdsarah merged commit 8b7811b into main Dec 21, 2022
@birdsarah birdsarah deleted the rateLimitFixSelenium branch December 21, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants