Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the settings code via inspector #5064

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Improve the settings code via inspector #5064

merged 1 commit into from
Nov 30, 2022

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented Nov 29, 2022

It turned out that we can cleanup the inspector + settings a lot using QT meta object.

@bakulf bakulf requested a review from brizental as a code owner November 29, 2022 11:56
@bakulf bakulf changed the base branch from main to addon November 29, 2022 11:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 38.41% // Head: 38.41% // No change to project coverage 👍

Coverage data is based on head (24207f3) compared to base (24207f3).
Patch has no changes to coverable lines.

❗ Current head 24207f3 differs from pull request most recent head f96761d. Consider uploading reports for the commit f96761d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5064   +/-   ##
=======================================
  Coverage   38.41%   38.41%           
=======================================
  Files         330      330           
  Lines       22145    22145           
  Branches    11966    11966           
=======================================
  Hits         8508     8508           
  Misses       5802     5802           
  Partials     7835     7835           
Flag Coverage Δ
functional_tests 27.74% <0.00%> (ø)
lottie_tests 23.06% <0.00%> (ø)
unit_tests 33.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bakulf bakulf force-pushed the updateSettings branch 2 times, most recently from c9809f2 to 9441a80 Compare November 29, 2022 15:57
Base automatically changed from addon to main November 29, 2022 19:24
@bakulf bakulf requested a review from strseb November 29, 2022 19:28
@bakulf bakulf merged commit 18152e6 into main Nov 30, 2022
@bakulf bakulf deleted the updateSettings branch November 30, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants