-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android CMake MVP #4769
Android CMake MVP #4769
Conversation
Codecov ReportBase: 61.92% // Head: 62.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4769 +/- ##
==========================================
+ Coverage 61.92% 62.11% +0.18%
==========================================
Files 327 327
Lines 21595 21632 +37
Branches 7072 10521 +3449
==========================================
+ Hits 13372 13436 +64
- Misses 6356 6367 +11
+ Partials 1867 1829 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# License, v. 2.0. If a copy of the MPL was not distributed with this | ||
# file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
||
. $(dirname $0)/../utils/commons.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set -e
Can you also change
And remove |
47ddfe1
to
c67dc63
Compare
We can do that, once we can do release builds with cmake. The adjust stuff is missing rn :) |
c67dc63
to
bd1f446
Compare
21f593a
to
a97b9cb
Compare
a97b9cb
to
0177b16
Compare
The original pr -> #4301 was a bit too much to chew of.
Turns out this worked fine with the current Qt, but on 6.4 we would have pain upgrading.
Let's be more iterative: this pr just switches from qmake to cmake for debug builds, as adjust files are missing. That will be the next followup :)
The whole android-deploy step remains unchanged.