Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Plattform Crash Reporting: Add Android Support #4484

Closed
wants to merge 16 commits into from

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Sep 19, 2022

This adds support to report crashes & errors for android to #4455

@strseb strseb changed the base branch from main to sentry September 19, 2022 15:46
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #4484 (a26b64d) into sentry (32651fe) will increase coverage by 27.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           sentry    #4484       +/-   ##
===========================================
+ Coverage   29.12%   56.33%   +27.20%     
===========================================
  Files         248       12      -236     
  Lines       13683      600    -13083     
  Branches     7851      287     -7564     
===========================================
- Hits         3985      338     -3647     
+ Misses       3920      262     -3658     
+ Partials     5778        0     -5778     
Flag Coverage Δ
lottie_tests 56.33% <ø> (ø)
qml_tests ?
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/constants.h
src/networkrequest.cpp
src/networkrequest.h
src/commandlineparser.h
src/tasks/function/taskfunction.h
src/models/keys.h
...s/conditionwatchers/addonconditionwatchergroup.cpp
src/websocket/pushmessage.cpp
src/rfc/rfc4193.cpp
src/addons/addon.h
... and 226 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -28,7 +28,7 @@ jobs:
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sentry_native repo itself has submodules:
https://github.com/getsentry/sentry-native/tree/master/external

src/sentry/sentryadapter.cpp Show resolved Hide resolved
@strseb strseb force-pushed the basti/sentry_android branch from 44cffe1 to 7d1bec1 Compare September 20, 2022 13:05
@strseb strseb closed this Nov 16, 2022
@strseb strseb deleted the basti/sentry_android branch February 9, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants