Fixes for PR3638 #3680
Merged
Fixes for PR3638 #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakulf
approved these changes
Jun 6, 2022
bakulf
added a commit
that referenced
this pull request
Jun 10, 2022
* Generate tutorial addons * Comment applied * Removed -g and -t params from generate_ts.sh * No 'name' var assigned * Load addons from manifest files * Split addons by types * Load and unload guides and tutorials * Update scripts/utils/generate_strings.py Co-authored-by: Francesco Lodolo <[email protected]> * Fixes for PR3638 (#3680) * Fix the unit-tests * Add python3-lxml as dep for linux packages * Fix a missing path * Fix the path for macos addons * Fix the strin generation script * Remove the addon folder * Addon index * Github action for addon generation * Review comments applied * metavar uppercase * Removed node for the wasm/addon github action Co-authored-by: Francesco Lodolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bakulf
This is built/open against your current PR. Feel free to close if it's not useful.
You can see the result of the action here
https://github.com/flodolo/mozilla-vpn-client/actions/runs/2447966583