Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webview auth code for iOS and Android #3502

Merged
merged 2 commits into from
May 11, 2022
Merged

Remove webview auth code for iOS and Android #3502

merged 2 commits into from
May 11, 2022

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented May 11, 2022

Description

This is dead code. In 2.8.0 we have released the auth in app.

Reference

https://mozilla-hub.atlassian.net/browse/VPN-2206

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #3502 (9f41dd3) into main (17466b5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3502      +/-   ##
==========================================
+ Coverage   51.47%   51.48%   +0.01%     
==========================================
  Files         281      272       -9     
  Lines       15828    15007     -821     
  Branches     5772     5532     -240     
==========================================
- Hits         8148     7727     -421     
+ Misses       6852     6600     -252     
+ Partials      828      680     -148     
Flag Coverage Δ
functional_tests 10.23% <ø> (ø)
lottie_tests ?
qml_tests ?
unit_tests 75.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/authenticationlistener.cpp 90.00% <ø> (ø)
src/commands/commandui.cpp 23.10% <ø> (ø)
src/mozillavpn.h 57.81% <ø> (-1.57%) ⬇️
lottie/lib/lottieprivatedocument.cpp 52.94% <0.00%> (-42.30%) ⬇️
lottie/lib/lottieprivatewindow.cpp 38.33% <0.00%> (-38.06%) ⬇️
lottie/lib/lottiestatus.h 59.25% <0.00%> (-5.26%) ⬇️
src/closeeventhandler.cpp 28.84% <0.00%> (-3.30%) ⬇️
src/models/whatsnewmodel.cpp 15.68% <0.00%> (-1.27%) ⬇️
lottie/lib/lottieprivate.cpp 31.19% <0.00%> (-1.21%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17466b5...9f41dd3. Read the comment docs.

@bakulf bakulf requested a review from strseb May 11, 2022 12:49
src/commands/commandui.cpp Outdated Show resolved Hide resolved
src/commands/commandui.cpp Show resolved Hide resolved
@bakulf bakulf requested a review from strseb May 11, 2022 13:04
@bakulf
Copy link
Collaborator Author

bakulf commented May 11, 2022

@strseb there some taskcluster failures. Can you please tell me if they are connected to my PR or not? and if not how to have them fixed?

@strseb
Copy link
Collaborator

strseb commented May 11, 2022

This mac runner seems to be busted again. @ahal - I think we had our mac runner stuck once, can you maybe help here again?
Wasm seems to be something about the translations - i can look into that.

@bakulf bakulf merged commit a973713 into main May 11, 2022
@bakulf bakulf deleted the deadCode branch May 11, 2022 18:57
@ahal
Copy link
Collaborator

ahal commented May 11, 2022

Thanks. For some reasons the pool (including the level 3 one) keeps getting into a bad state. Dave House has been getting them unstuck, but it keeps happening..

I'll file another relops JIRA ticket, but I think we're going to have to address the underlying cause here as this is happening much too frequently :/

aaronkollasch pushed a commit to aaronkollasch/mozilla-vpn-client that referenced this pull request May 31, 2022
* Remove iOS webview auth code

* Remove android webview auth code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants