Android: Fix Random Service starts in the client #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
android/daemon/src/main/java/org/mozilla/firefox/vpn/daemon/VPNService.kt
Show resolved
Hide resolved
android/daemon/src/main/java/org/mozilla/firefox/vpn/daemon/VPNService.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #3492 +/- ##
===========================================
- Coverage 53.20% 21.53% -31.68%
===========================================
Files 291 70 -221
Lines 17324 3019 -14305
Branches 5771 1391 -4380
===========================================
- Hits 9218 650 -8568
+ Misses 7362 1951 -5411
+ Partials 744 418 -326
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mbirghan
approved these changes
May 11, 2022
aaronkollasch
pushed a commit
to aaronkollasch/mozilla-vpn-client
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Default value here is "START_STICKY" - So if the OS stops the service not because of the unbind, Android will re-deliver the intent but without the extra "start-only".
We handle a start without extras as if the os requests-always on, thus enabling the vpn.
Start_NOT_STICKY means here that once the service is stopped by the os, we won't get a new intent to restart.
Reference
closes #3179