Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the model initialization before going to StateMain #3427

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented May 3, 2022

@bakulf bakulf requested a review from mbirghan May 3, 2022 13:10
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #3427 (b705410) into main (f1176a1) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3427      +/-   ##
==========================================
- Coverage   54.09%   53.19%   -0.90%     
==========================================
  Files         287      287              
  Lines       16825    16818       -7     
  Branches     5608     5605       -3     
==========================================
- Hits         9102     8947     -155     
- Misses       7031     7308     +277     
+ Partials      692      563     -129     
Flag Coverage Δ
functional_tests 7.85% <0.00%> (-2.25%) ⬇️
lottie_tests 56.82% <ø> (ø)
qml_tests 11.18% <ø> (ø)
unit_tests 75.01% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mozillavpn.cpp 3.83% <0.00%> (-2.62%) ⬇️
lottie/lib/lottiestatus.h 19.35% <0.00%> (-45.17%) ⬇️
...rc/tasks/controlleraction/taskcontrolleraction.cpp 0.00% <0.00%> (-35.60%) ⬇️
src/task.h 66.66% <0.00%> (-33.34%) ⬇️
src/tasks/heartbeat/taskheartbeat.cpp 0.00% <0.00%> (-28.13%) ⬇️
lottie/lib/lottieprivate.cpp 11.60% <0.00%> (-20.80%) ⬇️
src/features/featurefreetrial.h 80.00% <0.00%> (-20.00%) ⬇️
src/urlopener.cpp 5.55% <0.00%> (-16.67%) ⬇️
...sks/authenticate/desktopauthenticationlistener.cpp 2.94% <0.00%> (-11.77%) ⬇️
src/mozillavpn.h 51.56% <0.00%> (-7.82%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1176a1...b705410. Read the comment docs.

@bakulf bakulf merged commit 53ff7eb into main May 3, 2022
@bakulf bakulf deleted the iosFix branch May 3, 2022 16:33
aaronkollasch pushed a commit to aaronkollasch/mozilla-vpn-client that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants