Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Ubuntu packages with Qt6 support #2769

Merged
merged 13 commits into from
Mar 16, 2022
Merged

Build Ubuntu packages with Qt6 support #2769

merged 13 commits into from
Mar 16, 2022

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Feb 16, 2022

This updates our packaging scripts and workflows to bring Qt6 support to the Linux platform, using Qt6 packages built on my testing PPA at ppa:okirby/qt6-testing. To make these builds shippable to users, we should migrate these Qt6 package onto an official PPA managed by Mozilla.

So far, this is only implemented for Ubuntu packages. It seems at the present time the Qt6 linguist tools for Fedora have a bug that is breaking the language imports, so I have decided to leave them on Qt5 for the time being.

@oskirby oskirby force-pushed the qt6-linux-support branch 6 times, most recently from c0a919d to b330358 Compare February 16, 2022 07:40
@oskirby oskirby force-pushed the qt6-linux-support branch from 894e783 to faada36 Compare March 15, 2022 12:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #2769 (11d1f05) into main (77389fe) will decrease coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
- Coverage   74.39%   73.45%   -0.95%     
==========================================
  Files         199      199              
  Lines       10359    10398      +39     
  Branches     1149     1152       +3     
==========================================
- Hits         7707     7638      -69     
- Misses       2629     2737     +108     
  Partials       23       23              
Flag Coverage Δ
lottie_tests 93.35% <ø> (ø)
qml_tests 11.27% <ø> (+0.01%) ⬆️
unit_tests 72.43% <ø> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/networkrequest.h 0.00% <0.00%> (-100.00%) ⬇️
src/logger.cpp 80.39% <0.00%> (-10.72%) ⬇️
src/networkrequest.cpp 44.22% <0.00%> (-10.13%) ⬇️
...uthenticationinapp/authenticationinapplistener.cpp 60.79% <0.00%> (-6.16%) ⬇️
src/tasks/authenticate/taskauthenticate.cpp 37.50% <0.00%> (-5.00%) ⬇️
src/models/serverdata.cpp 88.88% <0.00%> (-0.16%) ⬇️
tests/auth/testsignupandin.cpp 93.30% <0.00%> (-0.12%) ⬇️
src/networkwatcher.cpp 2.17% <0.00%> (-0.05%) ⬇️
src/pinghelper.cpp 0.98% <0.00%> (ø)
src/authenticationlistener.cpp 82.75% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77389fe...11d1f05. Read the comment docs.

@oskirby oskirby requested review from bakulf and mkestler-rtp March 15, 2022 22:51
@oskirby oskirby changed the title WIP: Qt6 linux support Build Ubuntu packages with Qt6 support Mar 15, 2022
@oskirby oskirby marked this pull request as ready for review March 15, 2022 22:53
@@ -14,6 +14,8 @@ jobs:
wasmQt6:
name: Wasm Qt6
runs-on: ubuntu-20.04
env:
QTVERSION: 6.2.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bakulf bakulf merged commit 22c23e8 into main Mar 16, 2022
@bakulf bakulf deleted the qt6-linux-support branch March 16, 2022 07:24
bakulf added a commit that referenced this pull request Mar 16, 2022
bakulf added a commit that referenced this pull request Mar 16, 2022
@oskirby oskirby restored the qt6-linux-support branch March 17, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants