Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vpn 890 last cleanup of errant connection messages #2311

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

mkestler-rtp
Copy link
Contributor

No description provided.

Marcus Kestler added 2 commits November 10, 2021 14:37
I would have made this a state, but since the controller is tied to the UI, it made things difficult.  This works as well and is probably simpler.  Basic flag and timer when we connect and disconnect to ignore errors while the routes and interface become stable.
@mkestler-rtp mkestler-rtp requested a review from bakulf November 18, 2021 13:57
Copy link
Collaborator

@bakulf bakulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marcus and I have discussed this PR. This is a temporary solution before a refactoring of the Controller and the network manager.

@bakulf bakulf merged commit 5a21a2e into main Nov 18, 2021
@bakulf bakulf deleted the VPN-890-last-cleanup-of-errant-connection-messages branch November 18, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants