Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6581: disable adjust #10173

Merged
merged 1 commit into from
Jan 9, 2025
Merged

VPN-6581: disable adjust #10173

merged 1 commit into from
Jan 9, 2025

Conversation

mcleinman
Copy link
Collaborator

Description

We want to disable adjust, but in a way that we can re-enable it if we later decide to. Commenting out this section removes the MZ_ADJUST flag in the builds, which disables adjust.

You can verify that Adjust is not running by finding the log line Debug: Adjust not included in build. shortly after the app initializes, rather than Debug: Adjust included in build.. (Build with a placeholder Adjust token when testing this; without one, Adjust will never be included in the build whether that section is commented out or not.)

Reference

VPN-6581

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from oskirby January 8, 2025 22:03
Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥

@mcleinman mcleinman merged commit b589939 into main Jan 9, 2025
117 checks passed
@mcleinman mcleinman deleted the vpn-6581-disable-adjust branch January 9, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants