VPN-6799: Add tests for timeToMainScreen metric #10172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There has been some concern that we might have a regression in our
timeToMainScreen
performance, which is intended to measure the startup time of the application. To make sure that this isn't some bug in the metric accumulation itself, we should add a functional test to ensure that it's generating sensible data.Unfortunately, this turned into a bit of a mess. There was a hack in the code that used QML/JS to serialize the metric value for testing, but this fails when handling a histogram metric, like
TimingDistributionMetric
so this required some refactoring to make it go. In particular:BaseMetric
type to try and simplify how metrics are serialized, and give them a unified interface.CustomDistributionMetric
we use for RX/TX transfer stats still work.And after all that is done, we can now check the
timeToMainScreen
metric as follows:Reference
JIRA issue: VPN-6799
JIRA issue: VPN-6186
Checklist