Xcode 16 simulator fixes #10149
Draft
Xcode 16 simulator fixes #10149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a bug in the daemon recovery logic. The initialization steps starts with a QLocalSocket::abort() to clear the socket state and this can sometimes generate a disconnect signal, treating disconnection as an error can result in an infinite loop.
When running on mobile, we need to support a speculative onboarding connection in the controller. This is a special case handled in the iOS and Android controllers. To try and generalize this, lets add an onboarding state and reason to the controller and pass it down to the local-socket based daemons so that they can setup permissions and emit a disconnection to end the onboarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The iOS simulator doesn't currently run because the network extension will fail to start. To work around it, we can make use of the mock daemon as a substitute. However, trying to get this working required a handful of fixes specific for iOS. In particular:
Reference
Split from #10092
Checklist