Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6790 : Tweak Killer software detection #10135

Merged
merged 2 commits into from
Dec 19, 2024
Merged

VPN-6790 : Tweak Killer software detection #10135

merged 2 commits into from
Dec 19, 2024

Conversation

lesleyjanenorton
Copy link
Member

Description

KillerNetwork::systemAffected() consistently returns false due to permissions issues. This PR tweaks the way we detect Killer Networking Software to use WindowsUtils::getServiceStatus() instead of WindowsServiceManager::open() to get around this.

Reference

VPN-6790

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Sorry, something went wrong.

@lesleyjanenorton lesleyjanenorton requested review from oskirby and removed request for oskirby December 18, 2024 21:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lesleyjanenorton lesleyjanenorton merged commit 20d6aa1 into main Dec 19, 2024
119 of 120 checks passed
@lesleyjanenorton lesleyjanenorton deleted the vpn-6790 branch December 19, 2024 20:30
@lesleyjanenorton
Copy link
Member Author

For posterity: I have merged this with 1 test failure because I...

  • have ascertained this does not introduce the failure
  • have conferred with my conspirators and we are aligned
  • need to unblock QA by start of day tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants