Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove addon condition for testing #10124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcleinman
Copy link
Collaborator

Description

QA requested removal of the timing condition to make testing easier: https://mozilla-hub.atlassian.net/browse/FXVPN-32?focusedCommentId=974354

I've included "adding this back in" in the ticket to finalize this addon: https://mozilla-hub.atlassian.net/browse/FXVPN-280

Reference

https://mozilla-hub.atlassian.net/browse/FXVPN-32?focusedCommentId=974354

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from flodolo as a code owner December 11, 2024 23:59
@mcleinman mcleinman requested review from lesleyjanenorton and strseb and removed request for flodolo December 11, 2024 23:59
@mcleinman
Copy link
Collaborator Author

mcleinman commented Dec 12, 2024

The failing functional test is due to VPN-6778, and will be fixed by #10123.

Adding await vpn.setSetting('languageCode', 'fr'); to the start of the failing test allows it to pass. I believe it's safe to merge this. (Or we can wait for VPN-6778 to be merged in first, if preferred.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant