Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix evaluation for wasm functional tests #10087

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Dec 2, 2024

Description

I think this was introduced by #10053 which made an error in how we pass the generated test list to the functional test jobs. This should fix it and make the wasm job consistent with Linux and MacOS.

Reference

Introduced by #10053

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the fix-wasm-functional-test-matrix branch from 0c81b11 to 0e98aaf Compare December 2, 2024 18:55
@oskirby oskirby requested a review from mcleinman December 2, 2024 19:45
@oskirby oskirby marked this pull request as ready for review December 2, 2024 19:45
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oskirby oskirby merged commit 1ded824 into main Dec 2, 2024
117 checks passed
@oskirby oskirby deleted the fix-wasm-functional-test-matrix branch December 2, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants