Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6399: Add Linux Qt build dependencies for accessibility #10080

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Nov 28, 2024

Description

The smoking gun in the Qt build logs seems to be this:

Note: Disabling X11 Accessibility Bridge: D-Bus or AT-SPI is missing.

To enable X11 accesibility support, I think we just need to make sure that Qt is built with the development libraries libdbus-1-dev and libatspi2.0-dev installed.

Reference

JIRA Issue: VPN-6399

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby force-pushed the vpn-6399-static-linux-atspi branch from bf31491 to 298f3a0 Compare November 28, 2024 18:56
@oskirby oskirby marked this pull request as ready for review November 28, 2024 20:50
@oskirby oskirby requested a review from a team as a code owner November 28, 2024 20:50
@oskirby oskirby requested review from bhearsum and mcleinman and removed request for a team November 28, 2024 20:50
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add any checks to cmake or elsewhere to ensure this doesn't regress?

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oskirby oskirby merged commit d884f04 into main Dec 2, 2024
95 checks passed
@oskirby oskirby deleted the vpn-6399-static-linux-atspi branch December 2, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants