Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6647: Ensure the app is started with a systemd application scope #10079

Merged
merged 7 commits into from
Dec 5, 2024

Fix compile failure on Ubuntu/focal

0d96d93
Select commit
Loading
Failed to load commit list.
Merged

VPN-6647: Ensure the app is started with a systemd application scope #10079

Fix compile failure on Ubuntu/focal
0d96d93
Select commit
Loading
Failed to load commit list.
firefoxci-taskcluster / source-test-clang-tidy-android succeeded Nov 28, 2024 in 8m 8s

FirefoxCI (pull_request)

Clang-tidy (Treeherder push)

Details

View task in Taskcluster | View logs in Taskcluster | View task group in Taskcluster

Task Status

Started: 2024-11-28T23:29:51.184Z
Resolved: 2024-11-28T23:35:47.094Z
Task Execution Time: 5 minutes, 55 seconds, 910 milliseconds
Task Status: completed
Reason Resolved: completed
RunId: 0

Artifacts

- public/build//mozillavpn-sources-report.yaml
- public/build//shared-sources-report.yaml
- public/chain-of-trust.json
- public/chain-of-trust.json.sig
- public/logs/certified.log
- public/logs/live_backing.log
- public/logs/live.log


[taskcluster 2024-11-28 23:29:51.322Z] Task ID: Nc-a28dFRIGYtw3IrQZ8nA
[taskcluster 2024-11-28 23:29:51.322Z] Worker ID: 7369104701169943190
[taskcluster 2024-11-28 23:29:51.322Z] Worker Group: us-central1-c
[taskcluster 2024-11-28 23:29:51.323Z] Worker Node Type: projects/887720501152/machineTypes/n2-custom-32-73728
[taskcluster 2024-11-28 23:29:51.323Z] Worker Pool: mozillavpn-1/b-linux-large-gcp
[taskcluster 2024-11-28 23:29:51.323Z] Worker Version: 38.0.5
[taskcluster 2024-11-28 23:29:51.323Z] Public IP: 34.132.26.3
[taskcluster 2024-11-28 23:29:51.323Z] Hostname: mozillavpn-1-b-linux-large-gcp-belw4i96ra6udapmoxtwka
[taskcluster 2024-11-28 23:29:51.323Z] using cache "mozillavpn-level-1-checkouts-v3-0afbf72f72cb5ffedd2f-N3Bnjzv2RzaHix5-e3PKog" -> /builds/worker/checkouts

[taskcluster 2024-11-28 23:29:53.648Z] Downloading artifact "public/image.tar.zst" from task ID: N3Bnjzv2RzaHix5-e3PKog.
[taskcluster 2024-11-28 23:29:58.653Z] Download Progress: 8.77%
[taskcluster 2024-11-28 23:30:03.655Z] Download Progress: 20.27%
[taskcluster 2024-11-28 23:30:08.655Z] Download Progress: 24.11%
[taskcluster 2024-11-28 23:30:13.656Z] Download Progress: 35.62%
[taskcluster 2024-11-28 23:30:18.656Z] Download Progress: 37.81%
[taskcluster 2024-11-28 23:30:23.658Z] Download Progress: 52.61%
[taskcluster 2024-11-28 23:30:28.659Z] Download Progress: 65.76%
[taskcluster 2024-11-28 23:30:33.661Z] Download Progress: 74.52%
[taskcluster 2024-11-28 23:30:38.663Z] Download Progress: 95.90%

...(3411 lines hidden)...

[task 2024-11-28T23:35:39.879Z]     auto
[task 2024-11-28T23:35:39.879Z] /builds/worker/checkouts/vcs/src/releasemonitor.cpp:66:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.879Z]     TaskRelease* task =
[task 2024-11-28T23:35:39.879Z]     ^~~~~~~~~~~
[task 2024-11-28T23:35:39.879Z]     auto
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-11-28T23:35:39.879Z]     }
[task 2024-11-28T23:35:39.879Z]     ^
[task 2024-11-28T23:35:39.879Z] /builds/worker/checkouts/vcs/src/releasemonitor.cpp:65:3: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.879Z]   QTimer::singleShot(0, this, [] {
[task 2024-11-28T23:35:39.879Z]   ^
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.879Z]         singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-11-28T23:35:39.879Z]         ^
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), (lambda at /builds/worker/checkouts/vcs/src/releasemonitor.cpp:65:31)>'
[task 2024-11-28T23:35:39.879Z]                        QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-11-28T23:35:39.879Z]                        ^
[task 2024-11-28T23:35:39.879Z] 7160 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 7158 warnings (7157 in non-user code, 1 NOLINT).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmp1vu830rn.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/commands/commandstatus.cpp
[task 2024-11-28T23:35:39.879Z] 11167 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 11167 warnings (11167 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpzd1s6hr4.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequest.cpp
[task 2024-11-28T23:35:39.879Z] /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequest.cpp:59:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.879Z]   NetworkRequest* request = new NetworkRequest(static_cast<Task*>(parent()));
[task 2024-11-28T23:35:39.879Z]   ^~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.879Z]   auto
[task 2024-11-28T23:35:39.879Z] 9421 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 9420 warnings (9420 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpzsgxh4p1.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/captiveportal/captiveportal.cpp
[task 2024-11-28T23:35:39.879Z] 9272 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 9272 warnings (9272 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpxjkhgpq_.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/connectionhealth.cpp
[task 2024-11-28T23:35:39.879Z] 12385 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 12385 warnings (12385 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpxy67ct6b.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/commands/commandexcludeip.cpp
[task 2024-11-28T23:35:39.879Z] 10179 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 10179 warnings (10179 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpyp1aiur6.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/settingswatcher.cpp
[task 2024-11-28T23:35:39.879Z] 10525 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 10525 warnings (10525 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.879Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpwihxi37_.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/daemon/daemon.cpp
[task 2024-11-28T23:35:39.879Z] 8385 warnings generated.
[task 2024-11-28T23:35:39.879Z] Suppressed 8385 warnings (8385 in non-user code).
[task 2024-11-28T23:35:39.879Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpscajg75t.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/models/servercountrymodel.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/models/servercountrymodel.cpp:274:13: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-11-28T23:35:39.880Z]             std::bind(sortCountryCallback, std::placeholders::_1,
[task 2024-11-28T23:35:39.880Z]             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]             [capture0 = &collator](auto && PH1, auto && PH2) { return sortCountryCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), capture0); }
[task 2024-11-28T23:35:39.880Z] 12604 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 12603 warnings (12603 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmppkhlubs6.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/commands/commandui.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/commands/commandui.cpp:164:7: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]       MockDaemon* daemon = new MockDaemon(qApp);
[task 2024-11-28T23:35:39.880Z]       ^~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]       auto
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/commands/commandui.cpp:223:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]     QQmlApplicationEngine* engine = new QQmlApplicationEngine();
[task 2024-11-28T23:35:39.880Z]     ^~~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]     auto
[task 2024-11-28T23:35:39.880Z] 15308 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 15306 warnings (15306 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpzile4lum.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/models/user.cpp
[task 2024-11-28T23:35:39.880Z] 9270 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 9270 warnings (9270 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpxtshnba1.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/constants.cpp
[task 2024-11-28T23:35:39.880Z] 8940 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 8940 warnings (8940 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpe5wf21_8.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:42:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]   CaptivePortalRequest* request = new CaptivePortalRequest(this);
[task 2024-11-28T23:35:39.880Z]   ^~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]   auto
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-11-28T23:35:39.880Z]     }
[task 2024-11-28T23:35:39.880Z]     ^
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:33:3: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.880Z]   QTimer::singleShot(30 * 1000, this, [this]() {
[task 2024-11-28T23:35:39.880Z]   ^
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.880Z]         singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-11-28T23:35:39.880Z]         ^
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), (lambda at /builds/worker/checkouts/vcs/src/captiveportal/captiveportalrequesttask.cpp:33:39)>'
[task 2024-11-28T23:35:39.880Z]                        QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-11-28T23:35:39.880Z]                        ^
[task 2024-11-28T23:35:39.880Z] 9438 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 9437 warnings (9436 in non-user code, 1 NOLINT).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpbqso9ia9.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/controller.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/controller.cpp:996:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]     TaskFunction* task = new TaskFunction([]() {});
[task 2024-11-28T23:35:39.880Z]     ^~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]     auto
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/controller.cpp:997:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]     NetworkRequest* request = new NetworkRequest(task, 200);
[task 2024-11-28T23:35:39.880Z]     ^~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]     auto
[task 2024-11-28T23:35:39.880Z] 13083 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 13081 warnings (13081 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmp0pu92dh0.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/notificationhandler.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/notificationhandler.cpp:402:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]   AddonMessage* addonMessage = qobject_cast<AddonMessage*>(addon);
[task 2024-11-28T23:35:39.880Z]   ^~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]   auto
[task 2024-11-28T23:35:39.880Z] 11151 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 11150 warnings (11150 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmptjv8z31a.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/telemetry.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/telemetry.cpp:161:15: warning: Value stored to 'controller' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-11-28T23:35:39.880Z]   Controller* controller = vpn->controller();
[task 2024-11-28T23:35:39.880Z]               ^
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/telemetry.cpp:161:15: note: Value stored to 'controller' during its initialization is never read
[task 2024-11-28T23:35:39.880Z] 12591 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 12590 warnings (12590 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmp7xclcj5c.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/apppermission.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/apppermission.cpp:222:13: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-11-28T23:35:39.880Z]             std::bind(sortApplicationCallback, std::placeholders::_1,
[task 2024-11-28T23:35:39.880Z]             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]             [capture0 = &collator](auto && PH1, auto && PH2) { return sortApplicationCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), capture0); }
[task 2024-11-28T23:35:39.880Z] 12699 warnings generated.
[task 2024-11-28T23:35:39.880Z] Suppressed 12698 warnings (12698 in non-user code).
[task 2024-11-28T23:35:39.880Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.880Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmpnh8h3vd1.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/mozillavpn.cpp
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:463:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]   TaskAuthenticate* taskAuthenticate = new TaskAuthenticate(authenticationType);
[task 2024-11-28T23:35:39.880Z]   ^~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.880Z]   auto
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:671:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]   QString* buffer = new QString();
[task 2024-11-28T23:35:39.880Z]   ^~~~~~~
[task 2024-11-28T23:35:39.880Z]   auto
[task 2024-11-28T23:35:39.880Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:672:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.880Z]   QTextStream* out = new QTextStream(buffer);
[task 2024-11-28T23:35:39.881Z]   ^~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]   auto
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:953:22: warning: Value stored to 'products' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
[task 2024-11-28T23:35:39.881Z]     ProductsHandler* products = ProductsHandler::instance();
[task 2024-11-28T23:35:39.881Z]                      ^
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:953:22: note: Value stored to 'products' during its initialization is never read
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:1216:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.881Z]   TaskDeleteAccount* task = new TaskDeleteAccount(m_private->m_user.email());
[task 2024-11-28T23:35:39.881Z]   ^~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]   auto
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:1744:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.881Z]   NavigationBarButton* messageIcon = new NavigationBarButton(
[task 2024-11-28T23:35:39.881Z]   ^~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]   auto
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:1813:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
[task 2024-11-28T23:35:39.881Z]         ServiceAction a = (ServiceAction)type.toInt();
[task 2024-11-28T23:35:39.881Z]         ^~~~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]         auto
[task 2024-11-28T23:35:39.881Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:77:5: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
[task 2024-11-28T23:35:39.881Z]     }
[task 2024-11-28T23:35:39.881Z]     ^
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/mozillavpn.cpp:810:3: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.881Z]   QTimer::singleShot(0, this, &MozillaVPN::initializeGlean);
[task 2024-11-28T23:35:39.881Z]   ^
[task 2024-11-28T23:35:39.881Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:63:9: note: Calling 'QTimer::singleShot'
[task 2024-11-28T23:35:39.881Z]         singleShot(interval, defaultTypeFor(interval), receiver, std::forward<Functor>(slot));
[task 2024-11-28T23:35:39.881Z]         ^
[task 2024-11-28T23:35:39.881Z] /builds/worker/fetches/Qt/6.6.3/android_arm64_v8a/include/QtCore/qtimer.h:76:24: note: Calling 'makeCallableObject<void (*)(), void (MozillaVPN::*)()>'
[task 2024-11-28T23:35:39.881Z]                        QtPrivate::makeCallableObject<Prototype>(std::forward<Functor>(slot)));
[task 2024-11-28T23:35:39.881Z]                        ^
[task 2024-11-28T23:35:39.881Z] 16224 warnings generated.
[task 2024-11-28T23:35:39.881Z] Suppressed 16217 warnings (16216 in non-user code, 1 NOLINT).
[task 2024-11-28T23:35:39.881Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.881Z] /builds/worker/fetches/android_home/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/clang-tidy -export-fixes /tmp/tmpr_1nv9tz/tmphvvo13td.yaml -p=/builds/worker/checkouts/vcs/.tmp /builds/worker/checkouts/vcs/src/models/devicemodel.cpp
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/models/devicemodel.cpp:136:13: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-11-28T23:35:39.881Z]             std::bind(sortCallback, std::placeholders::_1,
[task 2024-11-28T23:35:39.881Z]             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]             [keys](auto && PH1, auto && PH2) { return sortCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), keys); }
[task 2024-11-28T23:35:39.881Z] /builds/worker/checkouts/vcs/src/models/devicemodel.cpp:211:17: warning: prefer a lambda to std::bind [modernize-avoid-bind]
[task 2024-11-28T23:35:39.881Z]                 std::bind(sortCallback, std::placeholders::_1,
[task 2024-11-28T23:35:39.881Z]                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-11-28T23:35:39.881Z]                 [keys](auto && PH1, auto && PH2) { return sortCallback(std::forward<decltype(PH1)>(PH1), std::forward<decltype(PH2)>(PH2), keys); }
[task 2024-11-28T23:35:39.881Z] 10830 warnings generated.
[task 2024-11-28T23:35:39.881Z] Suppressed 10828 warnings (10828 in non-user code).
[task 2024-11-28T23:35:39.881Z] Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
[task 2024-11-28T23:35:39.881Z] Writing fixes to /builds/worker/checkouts/vcs/.tmp/clang-tidy/mozillavpn-sources-report.yaml ...
[task 2024-11-28T23:35:39.881Z] + mkdir -p /builds/worker/artifacts/
[task 2024-11-28T23:35:39.881Z] + cp .tmp/clang-tidy/mozillavpn-sources-report.yaml .tmp/clang-tidy/shared-sources-report.yaml /builds/worker/artifacts/
[fetches 2024-11-28T23:35:39.881Z] removing /builds/worker/fetches
[fetches 2024-11-28T23:35:45.612Z] finished
[taskcluster 2024-11-28 23:35:46.010Z] === Task Finished ===
[taskcluster 2024-11-28 23:35:46.443Z] Successful task run with exit code: 0 completed in 355.122 seconds