Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert fail in auth tests #10073

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix assert fail in auth tests #10073

merged 1 commit into from
Nov 25, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Nov 25, 2024

Description

At some point in the past the auth tests were broken due to a bad assert that was causing the test worker to fail if there was no SettingsManager created. Rather than an assert, we should just check to see if the SettingsManager was created and handle the test cleanup accordingly.

There's a 99.999% chance that I am to blame for the failed test, but we just never noticed because we don't run the auth tests in PR.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review November 25, 2024 19:33
@oskirby oskirby requested review from strseb and mcleinman November 25, 2024 21:31
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oskirby oskirby merged commit 5cbd528 into main Nov 25, 2024
94 of 95 checks passed
@oskirby oskirby deleted the auth-test-crash branch November 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants