Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to pick a better flatpak cache key #10067

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Nov 23, 2024

Description

Since I am up to my eyeballs in getting the CI working better, the Flatpak build jobs are taking far too long for my liking.
It seems that the github action they are built with has support for caching, but we include the ${{ github.sha }} in it, which basically means the cache will never hit.

If we change that to ${{ github.event.pull_request.base.sha }} then at least pull requests will build off the cached build from main.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review November 23, 2024 04:32
@oskirby oskirby requested review from strseb and mcleinman November 23, 2024 04:33
Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oskirby oskirby merged commit 8e0df78 into main Nov 23, 2024
92 checks passed
@oskirby oskirby deleted the naomi-better-flatpak-cache branch November 23, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants