Try to pick a better flatpak cache key #10067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since I am up to my eyeballs in getting the CI working better, the Flatpak build jobs are taking far too long for my liking.
It seems that the github action they are built with has support for caching, but we include the
${{ github.sha }}
in it, which basically means the cache will never hit.If we change that to
${{ github.event.pull_request.base.sha }}
then at least pull requests will build off the cached build frommain
.Reference
Checklist