Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6616 and VPN-6617: Addon messages for 2.25 #10066

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Nov 22, 2024

Description

This is the first update message that uses the new "shared strings" file. Incredibly, we only are adding 2 translatable strings that will only be used for this version, instead of 15 that it would have been in the old version.

This PR also includes a small fix (and target.text) that allows successful builds when developing addons using shared strings.

There are two other addon-related PRs that are currently in review:

This PR cannot be merged into main before #10065 is merged into main, to ensure we don't add bad translation IDs. #10065 was merged.

Linter failures are fixed in #10045 - that either needs to be merged in first, or have the code change replicated in this PR

This is what it looks like:
Screenshot 2Screenshot

Reference

VPN-6616 and VPN-6617

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman requested a review from flodolo as a code owner November 22, 2024 22:45
@mcleinman mcleinman marked this pull request as draft November 22, 2024 22:45
@mcleinman
Copy link
Collaborator Author

This is ready for review - I've put it on draft as a reminder to not merge it before #10065.

@mcleinman
Copy link
Collaborator Author

Taking off draft as #10065 is merged

@mcleinman mcleinman marked this pull request as ready for review December 2, 2024 16:35
@mcleinman mcleinman merged commit a3005a2 into main Dec 2, 2024
100 checks passed
@mcleinman mcleinman deleted the vpn-6616-and-6617-2.25-messages branch December 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants