Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to src/translations directory #10063

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

mcleinman
Copy link
Collaborator

Description

It's been bugging me that we have both a ./translations directory and a ./src/translations directory. It seems like we moved almost everything to ./src/translations at one point, but left a couple files. Let's move those last couple, unless there is a good reason not to.

Reference

None

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``It's been bugging me that we` <- i am all for those types of pr! thank you!

@mcleinman mcleinman merged commit bb9d4ec into main Nov 21, 2024
117 checks passed
@mcleinman mcleinman deleted the remove-translations-folder branch November 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants