Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I introduced this bug right here, by replacing
color.overlayBackground = '#4D000000';
withcolor.overlayBackground = addTransparency(color.black, 0.0);
. Of course, 4D is 30%, not 0%.I went through and audited every other use of 0.0 transparency, to make sure I didn't have any other copy/paste errors. I found just one other spot that used 0.0 but the wrong color, and updated it as part of this PR. (Not all #00xxxxx colors are identical. While they look identical on screen, in transitions or with opacity changes they may look different. Changing all
addTransparency(color.[anything], 0.0)
tocolor.transparency
will cause UI bugs.)I also snuck two other things in here - a fix for a color name that needed to be updated, and a default
colorScheme
that suppresses some log warnings.This color was used beneath overlays and above the help drawers. As expected, this PR fixes both spots (before photos are in the Jira ticket):
Reference
VPN-6700
Checklist