Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6700: fix color #10059

Merged
merged 3 commits into from
Nov 21, 2024
Merged

VPN-6700: fix color #10059

merged 3 commits into from
Nov 21, 2024

Conversation

mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Nov 20, 2024

Description

I introduced this bug right here, by replacing color.overlayBackground = '#4D000000'; with color.overlayBackground = addTransparency(color.black, 0.0);. Of course, 4D is 30%, not 0%.

I went through and audited every other use of 0.0 transparency, to make sure I didn't have any other copy/paste errors. I found just one other spot that used 0.0 but the wrong color, and updated it as part of this PR. (Not all #00xxxxx colors are identical. While they look identical on screen, in transitions or with opacity changes they may look different. Changing all addTransparency(color.[anything], 0.0) to color.transparency will cause UI bugs.)

I also snuck two other things in here - a fix for a color name that needed to be updated, and a default colorScheme that suppresses some log warnings.

This color was used beneath overlays and above the help drawers. As expected, this PR fixes both spots (before photos are in the Jira ticket):
Screenshot 22Screenshot 21

Reference

VPN-6700

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@mcleinman mcleinman merged commit 499d5aa into main Nov 21, 2024
114 checks passed
@mcleinman mcleinman deleted the vpn-6700-fix-modal-color branch November 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants