basti/kn intervention #10042
Merged
basti/kn intervention #10042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcleinman
reviewed
Nov 15, 2024
src/webextensionadapter.cpp
Outdated
Comment on lines
7
to
8
| #include <qjsonarray.h> | ||
| #include <qjsonobject.h> |
There was a problem hiding this comment.
Aren't these already included on lines 11 and 13?
There was a problem hiding this comment.
truee, i have a new vscode addon that probably added that >:(
strseb
force-pushed
the
basti/kn_intervention
branch
from
bc6b8f1 to
9a997f2
Compare
|
@mcleinman this is ready for review, i've pulled the telemetry from this pr and moving this to another |
mcleinman
approved these changes
Dec 5, 2024
| @@ -33,6 +32,14 @@ | |||
| # include "platforms/windows/windowsutils.h" | |||
| #endif | |||
|
|
|||
| #if defined(MZ_LINUX) && !defined(MZ_FLATPAK) | |||
strseb
added a commit
that referenced
this pull request
Dec 10, 2024
* Add basic auto intervention * Add query api for interventions * Fixup * Update src/interventions/killernetwork.h Co-authored-by: MCleinman <[email protected]> * Remove wrong things --------- Co-authored-by: MCleinman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr adds the most basic code needed to make sure we handle intels KN service.
For this i want to add a concept of "Interventions" as
3rdparty Software that interferes with us and therefore we intervene. Hopefully, this will be an empty folder.For now let's add:
-> a detection for kn,
-> an API for the Extension to query detected interventions
-> Telemetry for kn, to make a rough case of how much we really should be focusing this on: should this just be a sumo article or do we really need to intervene.