Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: fix showWindow #10003

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Nit: fix showWindow #10003

merged 2 commits into from
Dec 10, 2024

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Oct 31, 2024

Description

Santiago told me we had an issue with the "open vpn" buttons in the extension not bringing it up.
So let's grab the native window handle and make sure to bump the window to the top of the stack if needed.

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Would love Lesley to take a look at this as well as I don't know this part of Qt, but I'm approving it in case you need this to unblock you quickly.

@strseb strseb enabled auto-merge (squash) December 10, 2024 12:22
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label Dec 10, 2024
@strseb strseb merged commit 144b314 into main Dec 10, 2024
119 of 121 checks passed
@strseb strseb deleted the basti/fix_focus branch December 10, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants